Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: japanese parenthesis #8381

Merged
merged 9 commits into from
May 3, 2023
Merged

fix: japanese parenthesis #8381

merged 9 commits into from
May 3, 2023

Conversation

benbenben2
Copy link
Collaborator

@benbenben2 benbenben2 commented Apr 30, 2023

What

added parenthesis that can be found in Japan as separator and parenthesis to extract the ingredients

Screenshot

Before
parenthesis_before
After
parenthesis_after

Related issue(s) and discussion

@benbenben2 benbenben2 self-assigned this Apr 30, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner April 30, 2023 21:09
@github-actions github-actions bot added 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🧪 tests labels Apr 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Merging #8381 (5c5fbd1) into main (d9d9c87) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8381      +/-   ##
==========================================
+ Coverage   48.14%   48.16%   +0.01%     
==========================================
  Files         109      109              
  Lines       21027    21028       +1     
  Branches     4741     4741              
==========================================
+ Hits        10124    10128       +4     
  Misses       9627     9627              
+ Partials     1276     1273       -3     
Impacted Files Coverage Δ
tests/unit/ingredients.t 100.00% <ø> (ø)
lib/ProductOpener/Ingredients.pm 90.89% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label May 1, 2023
@benbenben2
Copy link
Collaborator Author

benbenben2 commented May 1, 2023

added the slash found in Japanese
fixes #8345

Before
before_Slash

After
after_slash

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benbenben2 , the how to learn Perl page is intended to be generic, for Perl newcomers. So it's probably best to not put things that are specific to Product Opener (e.g. where we put logs etc.). The logs are documented here: https://github.com/openfoodfacts/openfoodfacts-server/blob/main/docs/dev/how-to-develop-using-docker.md Maybe the title could be more specific (e.g. How to develop and debug Product Opener using docker) cc @alexgarel

[
"jp-parenthesis",
{
lc => "jp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jp is the country code for Japan, but the language code for Japanese is "ja"

- [Learn Perl](https://learn.perl.org/) - Perl programming language tutorials for beginners.
- [Perl Maven](https://perlmaven.com/) - Perl programming tutorials, tips, and code examples.

# See the logs while running Perl locally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc.

But I would have made it a specific how to, and a "how-to-develop-using-perl" that links to how to learn perl, the how to use log, and how-to-write-and-run-tests.md, how-to-use-repl.md and how-to-use-vscode.md

@github-actions github-actions bot removed the 📚 Documentation Documentation issues improve the project for everyone. label May 2, 2023
@benbenben2
Copy link
Collaborator Author

benbenben2 commented May 2, 2023

thank @alexgarel and @stephanegigandet for the comments regarding the docs. It is rolled back for now. I will spend more time reading the docs and add it in the corresponding page in a future contribution if it is needed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label May 3, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 2f9efb4 into main May 3, 2023
@stephanegigandet stephanegigandet deleted the fix_japanese_parenthesis branch May 3, 2023 07:56
@teolemon teolemon added the 🇯🇵 Japan https://jp.openfoodfacts.org/ label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🇯🇵 Japan https://jp.openfoodfacts.org/ ⭐ top pull request Top pull request. 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese full width parenthesis not recognised
5 participants