-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: japanese parenthesis #8381
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8381 +/- ##
==========================================
+ Coverage 48.14% 48.16% +0.01%
==========================================
Files 109 109
Lines 21027 21028 +1
Branches 4741 4741
==========================================
+ Hits 10124 10128 +4
Misses 9627 9627
+ Partials 1276 1273 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added the slash found in Japanese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benbenben2 , the how to learn Perl page is intended to be generic, for Perl newcomers. So it's probably best to not put things that are specific to Product Opener (e.g. where we put logs etc.). The logs are documented here: https://github.com/openfoodfacts/openfoodfacts-server/blob/main/docs/dev/how-to-develop-using-docker.md Maybe the title could be more specific (e.g. How to develop and debug Product Opener using docker) cc @alexgarel
tests/unit/ingredients.t
Outdated
[ | ||
"jp-parenthesis", | ||
{ | ||
lc => "jp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jp is the country code for Japan, but the language code for Japanese is "ja"
- [Learn Perl](https://learn.perl.org/) - Perl programming language tutorials for beginners. | ||
- [Perl Maven](https://perlmaven.com/) - Perl programming tutorials, tips, and code examples. | ||
|
||
# See the logs while running Perl locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc.
But I would have made it a specific how to, and a "how-to-develop-using-perl" that links to how to learn perl, the how to use log, and how-to-write-and-run-tests.md, how-to-use-repl.md and how-to-use-vscode.md
thank @alexgarel and @stephanegigandet for the comments regarding the docs. It is rolled back for now. I will spend more time reading the docs and add it in the corresponding page in a future contribution if it is needed. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What
added parenthesis that can be found in Japan as separator and parenthesis to extract the ingredients
Screenshot
Before
![parenthesis_before](https://user-images.githubusercontent.com/110821832/235376214-c8698a9a-3aec-4481-aa72-f7bcb74bc144.png)
![parenthesis_after](https://user-images.githubusercontent.com/110821832/235376223-9e97997a-971d-4be6-b29a-82a70084fc32.png)
After
Related issue(s) and discussion