Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explore files in sorted order to make tests non-random #8384

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: explore files in sorted order to make tests non-random #8384

merged 1 commit into from
May 2, 2023

Conversation

stephanegigandet
Copy link
Contributor

This fixes a failing test in recent PRs.

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 2, 2023 10:45
@github-actions github-actions bot added the store label May 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

teolemon
teolemon approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. There could also be alleys for optimizing the way we run tests (eg time consuming / boring / unlikely to fail ones at the end and/or beginning)

@stephanegigandet stephanegigandet merged commit bf5e755 into main May 2, 2023
@stephanegigandet stephanegigandet deleted the sort-readdir branch May 2, 2023 11:26
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 2, 2023
Merged
@stephanegigandet stephanegigandet mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @teolemon