-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: non-vegetarian Brown Triangle India #8410
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## main #8410 +/- ##
=======================================
Coverage 48.46% 48.46%
=======================================
Files 114 114
Lines 21268 21268
Branches 4768 4768
=======================================
Hits 10308 10308
Misses 9677 9677
Partials 1283 1283 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Do you think that we could make a parent? I am wondering if there is something wrong with synonyms... see screenshots
|
It depends if we consider that the brown triangle is just a design change of the brown dot, in which case it makes sense to show the brown triangle even if the product had a brown dot. That's why I made it a synonym. The other option is to have 2 separate entries, for the brown dot and for the brown triangle. Both make sense I think. We could start with 2 separate entries, and later we can always them merge them if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends if we consider that the brown triangle is just a design change of the brown dot, in which case it makes sense to show the brown triangle even if the product had a brown dot. That's why I made it a synonym.
Fine for me to keep it as synonym. Seems we can have different logo depending of the synonym written, even though they are on the same line.
I suggest to put a common parent for both: "en:indian vegetarian mark" (see the snippet in my last message)
Not sure why some synonyms are not showing the logo (see screenshot above)
From krishanti on Slack:
https://openfoodfacts.slack.com/archives/C03RV686Y/p1683355107829579
"I've been adding new products & loving the nutrition analysis. I've also blogged about my experience here - https://mvark.blogspot.com/2023/05/openfoodfactsorg-wikipedia-of-food.html
While I respect the diversity offered which in turn offers useful insights on food choices across the globe, I hope the website adapts to make it more usable for Indians as there is a great need for food and nutritional awareness.
While it is great to see the green dot symbol (lacto-vegetarian food) being tracked, I suggest that the reddish-brown triangle symbol (it was a red dot earlier) which identifies non-vegetarian food be tracked as well while collecting data.
In 2021, FSSAI (Food Safety and Standards Authority of India) adopted a new symbol for non-vegetarian food items due to concerns that the combination of the old symbols were difficult for people with colour blindness to distinguish - https://en.wikipedia.org/wiki/Vegetarian_and_vegan_symbolism "