fix: nutrition edit warnings #8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template::Toolkit
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #8411 +/- ##
=======================================
Coverage 48.46% 48.47%
=======================================
Files 114 114
Lines 21268 21277 +9
Branches 4768 4770 +2
=======================================
+ Hits 10308 10314 +6
- Misses 9677 9679 +2
- Partials 1283 1284 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexgarel
reviewed
May 15, 2023
| var nutrient_value = \$(this).val().replace(',','.'); | ||
| var is_above_or_below_100 = (isNaN(nutrient_value) && nutrient_value != '-') || nutrient_value < 0 || nutrient_value > 100; | ||
| // if the nutrition facts are indicated per serving, the value can be above 100 | ||
| if ((nutrient_value > 100) && (\$('#nutrition_data_per_serving').is(':checked'))) { |
There was a problem hiding this comment.
can't we check that it's below serving size ?
There was a problem hiding this comment.
It's tricky, because serving size is parsed on the server (it can be specified with different units etc.), but the user can change it in the form while editing nutrients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the work of @jnsereko : #8258
It fixes some issues with the original PR, that were found when doing more testing before pushing to production.