Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added nitrate sulfate as suggestions in table #8412

Merged
merged 1 commit into from
May 12, 2023

Conversation

benbenben2
Copy link
Collaborator

What

1/ added both nitrate and sulfate as suggestion in the table (populate %nutriments_tables in Food.pm)
2/ added nitrate and sulfate to export csv because of 1/. In the comments in the beginning of the Export.pm file, it is written:

Use the list of fields from CProduct::Opener::Config::options{import_export_fields_groups}
and the list of nutrients from CProduct::Opener::Food::nutriments_tables to list fields
that need to be exported.

Screenshot

Depending of the country:
image
image
image

Both are in mg:
image

Both are exported:
image

Related issue(s) and discussion

fixes #8265

@benbenben2 benbenben2 self-assigned this May 12, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner May 12, 2023 16:05
@github-actions github-actions bot added Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels May 12, 2023
@benbenben2 benbenben2 force-pushed the feat_sulfate_nitrate branch from e5a1ba2 to 2ad3ec8 Compare May 12, 2023 16:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8412 (2ad3ec8) into main (a0cfac9) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #8412   +/-   ##
=======================================
  Coverage   48.46%   48.47%           
=======================================
  Files         114      114           
  Lines       21268    21277    +9     
  Branches     4768     4770    +2     
=======================================
+ Hits        10308    10314    +6     
- Misses       9677     9679    +2     
- Partials     1283     1284    +1     
Impacted Files Coverage Δ
lib/ProductOpener/Food.pm 62.47% <ø> (ø)
lib/ProductOpener/Import.pm 30.73% <0.00%> (-0.04%) ⬇️
lib/ProductOpener/Packaging.pm 75.00% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benbenben2 benbenben2 merged commit eadb61a into main May 12, 2023
@benbenben2 benbenben2 deleted the feat_sulfate_nitrate branch May 12, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Food.pm 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sulfates and nitrates are not in the nutrients' list
3 participants