Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update nova-group-unknown.svg #8436

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: Update nova-group-unknown.svg #8436

merged 1 commit into from
May 23, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 20, 2023

Hi everyone!

On the mobile app, we have some issues with the current version of the Unknown group's SVG file.

After regenerating it with Illustrator, it seems to be OK on our side.

Could it be possible to use this one instead?
But please check, there is no visual regression (I don't think, but always better).

Hi everyone!

On the mobile app, we have some issues with the current version of the Unknown group's SVG file.

After regenerating it with Illustrator, it seems to be OK on our side.

Could it be possible to use this one instead?
But please check, there is no visual regression (I don't think, but always better).
@g123k g123k requested a review from a team as a code owner May 20, 2023 10:48
@g123k g123k changed the title Update nova-group-unknown.svg fix:Update nova-group-unknown.svg May 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8436 (fbf58eb) into main (6068ff9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8436   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         114      114           
  Lines       21314    21314           
  Branches     4776     4776           
=======================================
  Hits        10347    10347           
  Misses       9679     9679           
  Partials     1288     1288           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k g123k changed the title fix:Update nova-group-unknown.svg fix: Update nova-group-unknown.svg May 20, 2023
@teolemon teolemon added Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova SVG labels May 20, 2023
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit f58b6ae into main May 23, 2023
@alexgarel alexgarel deleted the g123k-patch-1 branch May 23, 2023 08:24
@g123k
Copy link
Collaborator Author

g123k commented May 23, 2023

Thanks @alexgarel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova SVG
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants