feat: added quality facet error for reversed kcal and kj #8438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you've done all the following (You can delete the checklist before submitting)
What
added data quality error for reversed kj and kcal
Instead of the formula in issue #8394, we can use the exact opposite of the formula used for "en:energy-value-in-kcal-does-not-match-value-in-kj" (reverse kcal and kj, and reversed < and >, so that any kcal that is in the window 3.7*kj -2 and 4.7*kj + 2 can be considered as reversed kcal and kj)
Also added tests for "en:energy-value-in-kcal-does-not-match-value-in-kj" (see:
# TODO: add tests in /tests/unit/dataqualityfood.t
?!?)Screenshot
Related issue(s) and discussion