Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: rare legumes and wheat / divinfood project #8454

Merged
merged 4 commits into from
May 29, 2023
Merged

taxonomy: rare legumes and wheat / divinfood project #8454

merged 4 commits into from
May 29, 2023

Conversation

stephanegigandet
Copy link
Contributor

Some rare legumes and cereals that are of interest to the Divinfood EU project.

@github-actions github-actions bot added 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels May 24, 2023
@stephanegigandet
Copy link
Contributor Author

@benbenben2 Thanks a lot for all the additions! For some reason GitHub does not let me apply them, are you able to commit them?

@benbenben2
Copy link
Collaborator

@benbenben2 Thanks a lot for all the additions! For some reason GitHub does not let me apply them, are you able to commit them?

Same here, I have a "This diff has recently been updated. Refresh and try again." message when I try to apply changes. And refresh and update branch could not change anything.

@stephanegigandet
Copy link
Contributor Author

@benbenben2 I copied your suggestions manually. I removed the translations that are just latin, as it's not the usual name we find on food products, it's more of a wikipedia convention. In practice we do match Latin synonyms for ingredients in all languages already.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8454 (b46988f) into main (7b97896) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8454   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files         114      114           
  Lines       21343    21343           
  Branches     4779     4779           
=======================================
  Hits        10376    10376           
  Misses       9680     9680           
  Partials     1287     1287

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet merged commit 0442a1e into main May 29, 2023
@stephanegigandet stephanegigandet deleted the grass-pea branch May 29, 2023 07:50
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 29, 2023
Merged
MonalikaPatnaik pushed a commit to MonalikaPatnaik/openfoodfacts-server that referenced this pull request May 31, 2023
@stephanegigandet @benbenben2 @MonalikaPatnaik
taxonomy: rare legumes and wheat / divinfood project (openfoodfacts#8454
bd7bb65 
)

* taxonomy: rare wheat and legumes

* taxonomy: rare legumes and wheat / divinfood project

* tried to apply github suggestions

---------

Co-authored-by: benbenben2 <110821832+benbenben2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbenben2 benbenben2 benbenben2 approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @benbenben2 @codecov-commenter