Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update delete_user to append unique hash #8472

Merged
merged 4 commits into from
May 29, 2023
Merged

feat: Update delete_user to append unique hash #8472

merged 4 commits into from
May 29, 2023

Conversation

john-gom
Copy link
Contributor

What

When deleting a user renames them to anonymous with a unique random id. Increased MongoDB timeouts

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Merging #8472 (1b731d4) into main (819df0c) will decrease coverage by 0.01%.
The diff coverage is 10.00%.

❗ Current head 1b731d4 differs from pull request most recent head d5313a6. Consider uploading reports for the commit d5313a6 to get more accurate results

@@            Coverage Diff             @@
##             main    #8472      +/-   ##
==========================================
- Coverage   48.64%   48.64%   -0.01%     
==========================================
  Files         114      114              
  Lines       21354    21357       +3     
  Branches     4783     4781       -2     
==========================================
+ Hits        10388    10389       +1     
- Misses       9678     9680       +2     
  Partials     1288     1288              
Impacted Files Coverage Δ
lib/ProductOpener/Products.pm 42.41% <0.00%> (ø)
lib/ProductOpener/Users.pm 5.45% <50.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon added the Account deletion Enabling users to delete account while preserving accountability for edits label May 29, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@john-gom john-gom merged commit a510fec into main May 29, 2023
@john-gom john-gom deleted the issue/8164 branch May 29, 2023 16:14
MonalikaPatnaik pushed a commit to MonalikaPatnaik/openfoodfacts-server that referenced this pull request May 31, 2023
* Update delete_user to append unique hash

* Switched to own-generated unique suffix

* Make products_collection mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Account deletion Enabling users to delete account while preserving accountability for edits Products 👥 Users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to be removed while keeping moderation capabilities
4 participants