Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: Add CCPAE logo #8517

Merged
merged 3 commits into from
Jun 27, 2023
Merged

taxonomy: Add CCPAE logo #8517

merged 3 commits into from
Jun 27, 2023

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Jun 5, 2023 •
edited
Loading

What

Add CCPAE translations and logo from their website: https://www.ccpae.org/index.php?option=com_content&task=view&id=1161&Itemid=254&lang=en

  • Resized original image to 56x90
  • Rendered AI file to SVG (larger resolution)

@duhow duhow requested a review from a team as a code owner June 5, 2023 13:21
@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Jun 5, 2023
@teolemon teolemon added Spanish Catalan https://fr-ca.openfoodfacts.org/ https://es-ca.openfoodfacts.org/ labels Jun 6, 2023
@teolemon teolemon mentioned this pull request Jun 8, 2023
Open
alexgarel
alexgarel requested changes Jun 16, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duhow thank a lot for your contribution, and sorry for the delay.

You have to resize image so that's it's consistent with other labels (90px height). The image name must, of course, reflect new dimensions.

Would you mind changing that ?

@duhow duhow requested a review from alexgarel June 18, 2023 09:10
alexgarel
alexgarel approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the logo to "en" otherwise it would only have been visible in catalan.

Also it was not using the right name.

@alexgarel alexgarel enabled auto-merge (squash) June 27, 2023 14:44
@alexgarel
Copy link
Member

Thanks @duhow !

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 03cc780 into openfoodfacts:main Jun 27, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@duhow duhow

Labels
Catalan https://fr-ca.openfoodfacts.org/ https://es-ca.openfoodfacts.org/ labels Spanish 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duhow @alexgarel @teolemon