Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: new CIQUAL associations for ingredients #8537

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

stephanegigandet
Copy link
Contributor

Added new CIQUAL associations to ingredients, so that we can compute Nutri-Score for recipes made through the new Rate my recipe project. (see https://docs.google.com/document/d/1FZe_d8FRIEMt6afHvx80HMg5zdWURh-hFXCbd3Ohuu0/edit# for details about the project)

@github-actions github-actions bot added 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Jun 8, 2023
@teolemon
Copy link
Member

teolemon commented Jun 9, 2023

FYI @stephanegigandet @aleene and I have been working using this coordination spreadsheet in the past, that can be updated with improvements:
https://docs.google.com/spreadsheets/d/1inR_6f0KfPmJjV0NidEN7p5A5eeSSn4F/edit#gid=1104998590

@stephanegigandet stephanegigandet requested a review from a team as a code owner June 9, 2023 13:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.73%. Comparing base (783364b) to head (858ba71).
Report is 1408 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8537   +/-   ##
=======================================
  Coverage   48.73%   48.73%           
=======================================
  Files         114      114           
  Lines       21397    21397           
  Branches     4786     4786           
=======================================
  Hits        10428    10428           
  Misses       9685     9685           
  Partials     1284     1284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet stephanegigandet merged commit b99f70d into main Jun 15, 2023
@stephanegigandet stephanegigandet deleted the ratemyrecipe-ingredients branch June 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants