fix: add LCA icon in Eco-Score panel #8585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Agribalyse
Codecov Report
@@ Coverage Diff @@
## main #8585 +/- ##
=======================================
Coverage 48.79% 48.79%
=======================================
Files 114 114
Lines 21475 21475
Branches 4804 4804
=======================================
Hits 10478 10478
Misses 9705 9705
Partials 1292 1292 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
API
|
@teolemon can we merge this? it's likely to generate more merge conflicts if we wait |
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an icon in the Eco-Score subpanel for LCA.
Note that the LCA icon is always grey, as we currently have a mechanism only to change the color according to a good/average/bad evaluation, but not to a A to E grade color.
Fixes #8563