feat: Statistics for packagings materials by categories #8613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Garel <alex@garel.org>
…s.tt.json Co-authored-by: Alex Garel <alex@garel.org>
Codecov Report
@@ Coverage Diff @@
## main #8613 +/- ##
==========================================
- Coverage 48.79% 48.60% -0.19%
==========================================
Files 114 117 +3
Lines 21475 21747 +272
Branches 4804 4852 +48
==========================================
+ Hits 10478 10571 +93
- Misses 9705 9880 +175
- Partials 1292 1296 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
Display
📖 Knowledge Panels
stephanegigandet
changed the title
alexgarel
approved these changes
Jun 28, 2023
lib/ProductOpener/PackagingStats.pm
Outdated
Comment on lines
575
to
597
| # Export packaging components of all products to a CSV file | ||
| my $filehandle; | ||
| my $filename = "$www_root/data/$name.csv"; | ||
| open($filehandle, ">:encoding(UTF-8)", $filename) | ||
| or die("Could not write " . $filename . " : $!\n"); | ||
| my $csv = Text::CSV->new( | ||
| { | ||
| eol => "\n", | ||
| sep => "\t", | ||
| quote_space => 0, | ||
| binary => 1 | ||
| } | ||
| ) or die "Cannot use CSV: " . Text::CSV->error_diag(); | ||
|
|
||
| # Print the header line with fields names | ||
| $csv->print( | ||
| $filehandle, | ||
| [ | ||
| "code", "countries_tags", "categories_tags", "number_of_units", | ||
| "shape", "material", "parent_material", "recycling", | ||
| "weight", "weight_measured", "weight_specified", "quantity_per_unit" | ||
| ] | ||
| ); |
There was a problem hiding this comment.
style: typically the kind of thing I would like to have in a separate method, to avoid hindering code read. (something like: my ($filehandle, $csv) = init_products_packaging_components_csv())
There was a problem hiding this comment.
Good idea, will do.
Co-authored-by: Alex Garel <alex@garel.org>
Co-authored-by: Alex Garel <alex@garel.org>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
e.g. for yoghurts: