-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: activate Japanese ingredients processing #8621
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## main #8621 +/- ##
=======================================
Coverage 48.69% 48.70%
=======================================
Files 114 114
Lines 21417 21421 +4
Branches 4791 4791
=======================================
+ Hits 10430 10434 +4
Misses 9701 9701
Partials 1286 1286
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Good idea to have added the English translations in ingredients_text.
I will approve it now, but don't forget to apply your comment in Slack:
Right, for that one, I think the right solution is to add クリーミングパウダー in the ingredients taxonomy, as "creaming" is not an ingredient.
クリーミングパウダー is listed as an ingredient in several Japanese products we have.
I'll make a separate PR for the creaming powder. |
This PR builds upon the ingredients processing Japanese translations by @Naruyoko in #8617
The PR