Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not display empty packagings materials panel #8632

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: do not display empty packagings materials panel #8632

merged 1 commit into from
Jun 29, 2023

Conversation

stephanegigandet
Copy link
Contributor

Small fix to avoid an empty panel if we have not reprocessed packagings yet.

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner June 29, 2023 10:11
@github-actions github-actions bot added 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jun 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexgarel
alexgarel approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@alexgarel alexgarel enabled auto-merge (squash) June 29, 2023 10:17
@alexgarel alexgarel merged commit 6621834 into main Jun 29, 2023
@alexgarel alexgarel deleted the packagings-materials-panel-fix branch June 29, 2023 10:33
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel