Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: start of World Customs Organization Harmonized System properties for categories #8879

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Aug 17, 2023

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #8879 (15782ef) into main (41ba859) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8879   +/-   ##
=======================================
  Coverage   45.54%   45.54%           
=======================================
  Files          64       64           
  Lines       19519    19519           
  Branches     4738     4738           
=======================================
  Hits         8889     8889           
  Misses       9454     9454           
  Partials     1176     1176           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just suggest to give an example (see suggestion).
Looks good to me

@@ -50,6 +50,11 @@ stopwords:de:und,mit,von
# organic acid contributes to the total energy calculation. Only option is yes for this tag
# ignore_energy_calculated_error:en:yes

# World Customs Organizations Harmonized System Nomenclature properties
# e.g.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# e.g.
# e.g. for Linseed,
# under "SECTION II VEGETABLE PRODUCTS"
# it corresponds to "12 Oil seeds and oleaginous fruits; [...]".
# so, we click on "0212-2022E", we scroll down and we see "12.04 | 1204.00 | Linseed, whether or not broken."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants