Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add app landing page #8975

Merged
merged 4 commits into from
Sep 11, 2023
Merged

feat: Add app landing page #8975

merged 4 commits into from
Sep 11, 2023

Conversation

raphael0202
Copy link
Contributor

Linked to openfoodfacts/openfoodfacts-web#459

  • Plus Jakarta Sans font was added
  • We can now add new highlighted labels easily
  • add localized illustrations, more to come as the webpages are translated. Every illustration is stored in images/misc until we find a better alternative.

@raphael0202
fix: use "Plus Jakarta Sans" font for title
2867796 
According to brand guidelines, Plus Jakarta Sans should be used for
all titles
@raphael0202
refactor: make highlight spans usable anywhere
f352b44
@raphael0202 raphael0202 requested a review from a team as a code owner September 8, 2023 15:36
@github-actions github-actions bot added product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display labels Sep 8, 2023
teolemon
teolemon approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides the NPM lint issue

@raphael0202 raphael0202 enabled auto-merge (squash) September 11, 2023 13:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@raphael0202 raphael0202 merged commit f32eceb into main Sep 11, 2023
@raphael0202 raphael0202 deleted the add-app-landing-page branch September 11, 2023 14:16
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@raphael0202 raphael0202

Labels
CSS Display product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @teolemon