Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated ingredients_categories_and_types #9027

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

benbenben2
Copy link
Collaborator

What

Added piment in %ingredients_categories_and_types in Ingredients.pm.
Because it resulted to "piments de vert, piments de rouge, piments de jaune", a new variable (boolean) was added that can be set to 0 to indicate that there is no additional word ("de" or "d' ") between the categories (piment, for example) and the type (vert, for example).

Screenshot

Screenshot_20230919_195258

Related issue(s) and discussion

@benbenben2 benbenben2 requested a review from a team as a code owner September 19, 2023 18:03
@benbenben2 benbenben2 self-assigned this Sep 19, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Sep 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@a0e358e). Click here to learn what that means.
Report is 18 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9027   +/-   ##
=======================================
  Coverage        ?   46.15%           
=======================================
  Files           ?       64           
  Lines           ?    19862           
  Branches        ?     4797           
=======================================
  Hits            ?     9168           
  Misses          ?     9527           
  Partials        ?     1167           
Files Changed Coverage Δ
lib/ProductOpener/Ingredients.pm 92.06% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor suggestion to add "poivron" too

benbenben2 and others added 3 commits September 20, 2023 16:45
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Piments (vert, rouge, jaune) is not recognized by ingredients parsing
3 participants