-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated ingredients_categories_and_types #9027
fix: updated ingredients_categories_and_types #9027
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9027 +/- ##
=======================================
Coverage ? 46.15%
=======================================
Files ? 64
Lines ? 19862
Branches ? 4797
=======================================
Hits ? 9168
Misses ? 9527
Partials ? 1167
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one minor suggestion to add "poivron" too
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
What
Added piment in %ingredients_categories_and_types in Ingredients.pm.
Because it resulted to "piments de vert, piments de rouge, piments de jaune", a new variable (boolean) was added that can be set to 0 to indicate that there is no additional word ("de" or "d' ") between the categories (piment, for example) and the type (vert, for example).
Screenshot
Related issue(s) and discussion