feat: Use 'GS1 Barcode Syntax Engine' to normalize product codes

[hangy]

What

Use Perl module GS1::SyntaxEngine::FFI to normalize barcodes. This allows more GS1 strings to be used with search.

Related issue(s) and discussion

• Fixes Allow GS1 barcode types to be used in search #9013

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[stephanegigandet]

on the prod server, I'm getting an error when I try to install the module with cpan:

t/90-encoder-exception.t .. Can't enable unknown feature try at t/90-encoder-exception.t line 12.
BEGIN failed--compilation aborted at t/90-encoder-exception.t line 12.
t/90-encoder-exception.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
t/99-multi-opts.t ......... ok   

Test Summary Report
-------------------
t/90-encoder-exception.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=7, Tests=9,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.63 cusr  0.18 csys =  1.84 CPU)
Result: FAIL
Failed 1/7 test programs. 0/9 subtests failed.
Makefile:880: recipe for target 'test_dynamic' failed
make: *** [test_dynamic] Error 255
  HANGY/GS1-SyntaxEngine-FFI-0.3.tar.gz
  /usr/bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
  reports HANGY/GS1-SyntaxEngine-FFI-0.3.tar.gz
Failed during this command:
 HANGY/GS1-SyntaxEngine-FFI-0.3.tar.gz        : make_test NO

[hangy]

Can't enable unknown feature try at t/90-encoder-exception.t line 12.

Sounds like an old Perl version. The normal code doesn't use try - just the test: https://github.com/search?q=repo%3Ahangy%2Fstunning-goggles%20try&type=code So it should work, if you install with --no-test?

[stephanegigandet]

Tested on the .dev server (on stretch), it works

https://world.openfoodfacts.dev/api/v3/product/(01)04044782317112(17)270101