Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Even more beer categories #9181

Merged
merged 20 commits into from
Oct 25, 2023
Merged

taxonomy: Even more beer categories #9181

merged 20 commits into from
Oct 25, 2023

Conversation

DanieliusAsm
Copy link
Contributor

@DanieliusAsm DanieliusAsm commented Oct 21, 2023

What

  • Added some more beer categories
  • Added a lot of descriptions to better understand categories.
  • Most of the work was done towards Lagers - one of the primary types of beers.

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Oct 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #9181 (0011798) into main (dd02264) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9181   +/-   ##
=======================================
  Coverage   48.00%   48.00%           
=======================================
  Files          64       64           
  Lines       20087    20087           
  Branches     4876     4876           
=======================================
  Hits         9642     9642           
  Misses       9188     9188           
  Partials     1257     1257           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aleene
Copy link
Contributor

aleene commented Oct 22, 2023

Great work. I wonder how you decide when a new category is needed. A category should have the function to help a user decide between products within a category based on any product attribute. If there are only very few products within the category, a category has no sense. This however might change for the better when new products are added.

@DanieliusAsm
Copy link
Contributor Author

DanieliusAsm commented Oct 22, 2023

@aleene I scanned and added a lot of beers. Before me there were only 2 lithuanian beers and now theres 293. Some of them had these categories that I am adding, but there are other categories that I just got from a beer chart online and they might not have any products currently. Like Grodziskie doesnt have any but is considered a historical beer that nearly went extinct.

The PR where I added lots of IPA's was where I went through all IPA's uploaded on Openfoodfacts and found out about them.

I Guess I also thought about the future. Maybe it would be possible to get a beer community to join OFF and scan and add lots of beers.

But just adding categories isnt enough since I would need to go through and assign those categories to current beers (based on their names)

@aleene
Copy link
Contributor

aleene commented Oct 22, 2023

Great that you reviewed the already available beers already. You might have noticed that I added a few in the years. For a long time beers was my top category.
It would be great to have beer enthusiasts sign up and add beers. Especially as I have a big worry on beer categorisation. Who understands beers enough to be able to categorise them. Any help you can enter in the taxonomy is very helpful. It can take the form of "look for these words then it belongs there". In the future OFF will provide more help to the user and these sentences should form the basis for that.

@stephanegigandet stephanegigandet changed the title taxonomy:Even more beer categories taxonomy: Even more beer categories Oct 25, 2023
@alexgarel
Copy link
Member

really cool to see that kind of contribution @DanieliusAsm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants