-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Even more beer categories #9181
taxonomy: Even more beer categories #9181
Conversation
…sm/openfoodfacts-server into beers-and-ingredients
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## main #9181 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 64 64
Lines 20087 20087
Branches 4876 4876
=======================================
Hits 9642 9642
Misses 9188 9188
Partials 1257 1257 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Great work. I wonder how you decide when a new category is needed. A category should have the function to help a user decide between products within a category based on any product attribute. If there are only very few products within the category, a category has no sense. This however might change for the better when new products are added. |
@aleene I scanned and added a lot of beers. Before me there were only 2 lithuanian beers and now theres 293. Some of them had these categories that I am adding, but there are other categories that I just got from a beer chart online and they might not have any products currently. Like Grodziskie doesnt have any but is considered a historical beer that nearly went extinct. The PR where I added lots of IPA's was where I went through all IPA's uploaded on Openfoodfacts and found out about them. I Guess I also thought about the future. Maybe it would be possible to get a beer community to join OFF and scan and add lots of beers. But just adding categories isnt enough since I would need to go through and assign those categories to current beers (based on their names) |
Great that you reviewed the already available beers already. You might have noticed that I added a few in the years. For a long time beers was my top category. |
really cool to see that kind of contribution @DanieliusAsm ! |
What