Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing producers images for pro platform #9383

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix: add missing producers images for pro platform #9383

merged 2 commits into from
Nov 23, 2023

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet requested a review from a team as a code owner November 23, 2023 13:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (387568f) 48.68% compared to head (f6ef408) 48.68%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9383   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files          65       65           
  Lines       20268    20268           
  Branches     4896     4896           
=======================================
  Hits         9867     9867           
  Misses       9141     9141           
  Partials     1260     1260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alexgarel
alexgarel approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@alexgarel alexgarel enabled auto-merge (squash) November 23, 2023 15:08
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit ae71756 into main Nov 23, 2023
13 checks passed
@alexgarel alexgarel deleted the producers-images2 branch November 23, 2023 15:36
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many images are 404 on the pro website
3 participants
@stephanegigandet @codecov-commenter @alexgarel