Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: dq_serving_size_parsing_improvements #9484

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

benbenben2
Copy link
Collaborator

What

Reviewed the Mirabelle results from the issue for serving size (see below)

Here are 100 examples randomly: http://mirabelle.openfoodfacts.org/products?sql=select+code%2C+url%2C+creator%2C+created_datetime%2C+last_modified_datetime%2C+product_name%2C+serving_size%2C+serving_quantity%0D%0Afrom+%5Ball%5D+%0D%0Awhere+%28serving_quantity+%3D%3D+%22%22+or+serving_quantity+IS+NULL%29+and+%28serving_size+%21%3D+%22%22%29%0D%0Aorder+by+random%28%29%0D%0Alimit+100

Brazil (pt:) added "gm". 5,484 rows
xx:onz, 128 rows
en:metric teaspoon 2 rows
note that beside metric teaspoon, teaspoon or tsp depends on the country (us, uk, canada)
same for cup and tbsp which is also a factor of the density (i.e., 1 tbsp of water will be different than 1 tbsp of sugar, for example)
gg instead of g is typo, not added in taxonomy. It has to be fixed by contributors.

Related issue(s) and discussion

@benbenben2 benbenben2 added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧽 Data quality https://wiki.openfoodfacts.org/Quality Taxonomies labels Dec 5, 2023
@benbenben2 benbenben2 self-assigned this Dec 5, 2023
@benbenben2 benbenben2 requested a review from a team as a code owner December 5, 2023 21:05
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 4f0760b into main Dec 12, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the dq_serving_size_parsing_improvements branch December 12, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants