Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove transparency of PNG images without a .png extension, fixe… #9632

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

stephanegigandet
Copy link
Contributor

fixes #9621

this PR fixes the issue but does not include tests, I filed a new issue for the tests: #9631

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d295d1) 49.29% compared to head (3848447) 49.29%.

Files Patch % Lines
lib/ProductOpener/Images.pm 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9632   +/-   ##
=======================================
  Coverage   49.29%   49.29%           
=======================================
  Files          66       66           
  Lines       20551    20551           
  Branches     4949     4949           
=======================================
  Hits        10130    10130           
  Misses       9132     9132           
  Partials     1289     1289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet stephanegigandet merged commit db94830 into main Jan 9, 2024
13 checks passed
@stephanegigandet stephanegigandet deleted the images-upload branch January 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG files transparent background is transformed to black background if it's selected as front
3 participants