Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docker profile repetition for postgresql container #9693

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

alexgarel
Copy link
Member

docker compose is picky about that

@alexgarel alexgarel requested a review from a team as a code owner January 25, 2024 17:57
@github-actions github-actions bot added the 🐋 Docker https://docker-curriculum.com/ label Jan 25, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Jan 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2319dcb) 49.44% compared to head (f1c70d3) 49.45%.
Report is 2 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/Display.pm 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9693   +/-   ##
=======================================
  Coverage   49.44%   49.45%           
=======================================
  Files          67       67           
  Lines       20644    20645    +1     
  Branches     4978     4978           
=======================================
+ Hits        10208    10209    +1     
  Misses       9139     9139           
  Partials     1297     1297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgarel alexgarel merged commit 55a9b22 into main Jan 30, 2024
12 checks passed
@alexgarel alexgarel deleted the build-docker-profile-postgres branch January 30, 2024 13:20
john-gom pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐋 Docker https://docker-curriculum.com/ ⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants