Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: last_modified_t needs to be a number and not a string #9705

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

stephanegigandet
Copy link
Contributor

fix #9686

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad0197f) 49.39% compared to head (feaf614) 49.44%.
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9705      +/-   ##
==========================================
+ Coverage   49.39%   49.44%   +0.04%     
==========================================
  Files          66       67       +1     
  Lines       20602    20644      +42     
  Branches     4971     4978       +7     
==========================================
+ Hits        10177    10208      +31     
- Misses       9132     9139       +7     
- Partials     1293     1297       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but why did it happened ? Isn't there any point in Product.pm to fix ?

@stephanegigandet
Copy link
Contributor Author

LGTM but why did it happened ? Isn't there any point in Product.pm to fix ?

it happened in a recent change in update_all_products.pl, it's fixed in this PR, and the PR also has a new option to fix the products that were affected

@alexgarel alexgarel merged commit 3f42fa7 into main Jan 29, 2024
13 checks passed
@alexgarel alexgarel deleted the last_modified_t branch January 29, 2024 15:48
john-gom pushed a commit that referenced this pull request May 24, 2024
it happened in a recent change in update_all_products.pl, it's fixed in this PR, and the PR also has a new option to fix the products that were affected

fix #9686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Recently modified" view is broken on the home page
3 participants