Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated z-index of map #9935

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

deveshidwivedi
Copy link
Contributor

@deveshidwivedi deveshidwivedi commented Mar 18, 2024

What

When scrolling, the map would cover other content. This PR corrects the z-index for the same for normal functioning and better UI.

Screenshot

Before:
Screenshot 2024-03-18 031604

After:
Screenshot 2024-03-18 031634

Related issue(s) and discussion

@deveshidwivedi deveshidwivedi requested a review from a team as a code owner March 18, 2024 07:04
@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Mar 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.52%. Comparing base (dc04d18) to head (55935cc).
Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9935      +/-   ##
==========================================
- Coverage   49.54%   49.52%   -0.02%     
==========================================
  Files          67       71       +4     
  Lines       20650    20899     +249     
  Branches     4980     5019      +39     
==========================================
+ Hits        10231    10351     +120     
- Misses       9131     9254     +123     
- Partials     1288     1294       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet
Copy link
Contributor

@deveshidwivedi Thank you! There is another place that we display a map: http://world.openfoodfacts.localhost/packager-code/fr-80-001-002-ce
in templates/web/pages/tag/tag.tt.html

Could you make a similar change there too? Thank you!

@github-actions github-actions bot added the Tags label Mar 18, 2024
@deveshidwivedi
Copy link
Contributor Author

Updated @stephanegigandet, thank you!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @deveshidwivedi!

@stephanegigandet stephanegigandet merged commit 88fbd42 into openfoodfacts:main Mar 18, 2024
13 checks passed
@deveshidwivedi deveshidwivedi deleted the map-z-index branch March 19, 2024 15:25
john-gom pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Tags Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEW DESIGN - z-index of the map is weird
3 participants