Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the elastic search query in a more precise and flexible way #117

Open
alexgarel opened this issue Jun 3, 2024 · 1 comment
Open

Comments

@alexgarel
Copy link
Member

alexgarel commented Jun 3, 2024

What

  • Right now we extract bare words from the query in unknown operation and filter them out to treat them separately.
  • But the implementation is quite faulty:
    • at least we should harvest words as we remove them from expressions
    • we should verify in the transformer if we are in a SearchTerm or not !

Proposed solution

  • But if we want to support complex expressions, instead of separating bare words, we should specialize the elastic search query builder so that it handles our bare words using our target expression.
  • Also we should support Phrase, not only Word.

Part of

@github-project-automation github-project-automation bot moved this to Todo (selected) in 🔎 Search-a-licious Jun 3, 2024
@alexgarel alexgarel changed the title Create the elastic search query in a more precise way Create the elastic search query in a more precise and flexible way Jun 4, 2024
@alexgarel
Copy link
Member Author

I changed the implementation to be more straightforward while keeping the full text term / filters separation.

It's good enough for now but this ticket will be kept open because the good solution is to correctly change the Word search as we transform the tree to an ES query.

@alexgarel alexgarel moved this from Todo (selected) to Backlog (ready for dev) in 🔎 Search-a-licious Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog (ready for dev)
Development

No branches or pull requests

2 participants