fix: improve "npx playwright install-deps" in frontend/dockerfile #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command is broken on Linux Mint 21 (Vanessa) Replaced by an exhaustive apt-get install obtained by executing "npm playwright install-deps --dry-run" The dependencies list shouldn't change regularly.
|
This change breaks Package 'xfonts-cyrillic' has no installation candidateWe should find another solution ^^ |
alexgarel
reviewed
Jun 5, 2024
EDIT: I'm wrong here ! It does not exists in bookworm ! Strange because it should exist: https://packages.debian.org/bookworm/xfonts-cyrillic and node:lts is based upon bookworm (see https://hub.docker.com/_/node) |
* Keep mount=type=cache * use node:lts-bullseye
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
make buildwas broken on my Linux Mint 21 because of this linenpm playwright install-deps chromium.The solution is to replace this line by an exhaustive
apt-get install.