feat: Count result #151
Merged
feat: Count result #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have access to number of result only in search-results component |
|
@alexgarel handleResults() is not triggered when a search is launched. Any idea why ? |
alexgarel
reviewed
Jun 12, 2024
| import { SearchResultEvent } from './events'; | ||
| import { SearchaliciousResultCtlMixin, SearchaliciousResultsCtlInterface } from './search-results-ctl'; | ||
|
|
||
| @customElement('results-counter-display') |
There was a problem hiding this comment.
I start every component name with "searchalicious" to avoid clashes (webcomponents should have unique names).
alexgarel
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Display count results on the search result page