Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update search bar to add "Search" text to encourage the user to search and add reset button #188

Merged
merged 6 commits into from
Jun 26, 2024
Merged

feat: update search bar to add "Search" text to encourage the user to search and add reset button #188

merged 6 commits into from
Jun 26, 2024

Conversation

Kout95
Copy link
Collaborator

@Kout95 Kout95 commented Jun 24, 2024

What

Screenshot

image

@Kout95 Kout95 changed the title Update search bar to add "Search" text when query changed and add reset button Update search bar to add "Search" text to encourage the user to search and add reset button Jun 24, 2024
@Kout95 Kout95 changed the title Update search bar to add "Search" text to encourage the user to search and add reset button feat : update search bar to add "Search" text to encourage the user to search and add reset button Jun 24, 2024
@Kout95 Kout95 changed the title feat : update search bar to add "Search" text to encourage the user to search and add reset button feat: update search bar to add "Search" text to encourage the user to search and add reset button Jun 24, 2024
@Kout95 Kout95 requested a review from Marc-AntoineA June 25, 2024 09:41
alexgarel
alexgarel approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I see it does not put "search" on click on a facet, but I imagine it is a different PR.

@alexgarel alexgarel merged commit 93d1ff2 into main Jun 26, 2024
11 checks passed
@alexgarel alexgarel deleted the update-search-bar branch June 26, 2024 06:46
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@Marc-AntoineA Marc-AntoineA Awaiting requested review from Marc-AntoineA

Assignees

@Kout95 Kout95

Labels
None yet
Projects
🔎 Search-a-licious
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kout95 @alexgarel