feat: #2501 - added "origins" in edit product page #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `app_en.arb`: added 2 labels for "origins" * `app_fr.arb`: added 2 labels for "origins" * `edit_product_page.dart`: added an item for "origins" * `product_query.dart`: added field "origins" to the list of the product fields we retrieve * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded to `openfoodfacts: ^1.22.0`, which has new product field "origins" * `simple_input_page_helpers.dart`: implementation for "origins" of a simple input page item
Codecov Report
@@ Coverage Diff @@
## develop #2571 +/- ##
==========================================
- Coverage 8.86% 7.55% -1.32%
==========================================
Files 161 210 +49
Lines 6623 10103 +3480
==========================================
+ Hits 587 763 +176
- Misses 6036 9340 +3304
Continue to review full report at Codecov.
|
|
The last of Eco-Score components 👌 |
Impacted files: * `simple_input_page_helpers.dart`
teolemon
reviewed
Jul 11, 2022
|
Done: |
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
teolemon
approved these changes
Jul 11, 2022
AshAman999
approved these changes
Jul 11, 2022
|
Thank you very much @monsieurtanuki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
app_en.arb: added 2 labels for "origins"app_fr.arb: added 2 labels for "origins"edit_product_page.dart: added an item for "origins"product_query.dart: added field "origins" to the list of the product fields we retrievepubspec.lock: wtfpubspec.yaml: upgraded toopenfoodfacts: ^1.22.0, which has new product field "origins"simple_input_page_helpers.dart: implementation for "origins" of a simple input page itemWhat
Screenshot
Fixes bug(s)