Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial download of a product for offline mode could remove KP #2667

Closed
teolemon opened this issue Jul 27, 2022 · 0 comments · Fixed by #2693
Closed

Partial download of a product for offline mode could remove KP #2667

teolemon opened this issue Jul 27, 2022 · 0 comments · Fixed by #2693
Labels
🐛 bug Something isn't working Offline - Browsing

Comments

@teolemon
Copy link
Member

if you already have product 0000, downloading product 0000 without the KP will actually remove the KP from it.
About existing products knowledge panels being removed, could probably,

  • 1st I have to get 1000 products from API then check if it's already in the DB then don't update it, I don't know how much time complexity it will add for that
  • 2nd we try to update the product anyways when we do a scan, so i guess it won't be a big problem

Originally posted by @AshAman999 in #2661 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Offline - Browsing
Development

Successfully merging a pull request may close this issue.

1 participant