Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: productQueryPage - refactored without ScaffoldMessenger #2769

Merged

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • product_query_page.dart: refactored without ScaffoldMessenger, which has no impact on the app but bigger impact on the code format.

What

  • Just removed a now useless Widget, which has only an impact on code format.
  • The idea was NOT to code relevant changes while changing the format too - easier to review this way

Impacted file:
* `product_query_page.dart`: refactored without `ScaffoldMessenger`, which has no impact on the app but bigger impact on the code format.
@codecov-commenter
Copy link

Codecov Report

Merging #2769 (7a6171e) into develop (2ea0da3) will decrease coverage by 1.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2769      +/-   ##
==========================================
- Coverage     8.86%   7.12%   -1.74%     
==========================================
  Files          161     218      +57     
  Lines         6623   10622    +3999     
==========================================
+ Hits           587     757     +170     
- Misses        6036    9865    +3829     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 62.26% <0.00%> (-20.72%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) ⬇️
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 2.50% <0.00%> (-2.27%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
... and 237 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki merged commit 04d311e into openfoodfacts:develop Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants