fix: #2776 - more standard user preferences app bar #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `user_preferences_account.dart`: unrelated uniformization of list tile display in preferences * `user_preferences_food.dart`: unrelated uniformization of list tile display in preferences * `user_preferences_page.dart`: removed the sliver effect
Codecov Report
@@ Coverage Diff @@
## develop #2780 +/- ##
==========================================
- Coverage 8.86% 7.04% -1.82%
==========================================
Files 161 218 +57
Lines 6623 10640 +4017
==========================================
+ Hits 587 750 +163
- Misses 6036 9890 +3854
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Not 100% related and just trying: what about this? |
|
Really like the looks, not just from the PR but also from your suggestion. but it will likely again cause scroll problems as we had with the sliders |
|
@M123-dev No problem. I'll do that in a different PR today. |
|
Don't rush doing it there are a lot of things we have to consider for the preferences should probably be discussed first |
|
@M123-dev I just have fun doing it. It can be merged much later, or never. |
M123-dev
approved these changes
Aug 12, 2022
|
@M123-dev Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
user_preferences_account.dart: unrelated uniformization of list tile display in preferencesuser_preferences_food.dart: unrelated uniformization of list tile display in preferencesuser_preferences_page.dart: removed the sliver effectWhat
Screenshot
Fixes bug(s)