Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2553 - upgrade to off-dart 1.24.0 + categories not completed #2795

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • paged_product_query.dart: replaced deprecated method from off-dart 1.24.0
  • paged_to_be_completed_product_query.dart: edited as "CATEGORIES not completed"; replaced deprecated method from off-dart 1.24.0
  • product_list_import_export.dart: replaced deprecated method from off-dart 1.24.0
  • product_list_page.dart: replaced deprecated method from off-dart 1.24.0
  • pubspec.lock: generated
  • pubspec.yaml: upgrade to off-dart 1.24.0

What

  • Quick fix about the upgrade to off-dart 1.24.0 (deprecated methods)
  • Quick fix regarding "all to be completed" product query - now we target "categories not completed"

Screenshot

France World
Capture d’écran 2022-08-16 à 13 42 27 Capture d’écran 2022-08-16 à 13 42 47

Fixes bug(s)

… completed

Impacted files:
* `paged_product_query.dart`: replaced deprecated method from off-dart 1.24.0
* `paged_to_be_completed_product_query.dart`: edited as "CATEGORIES not completed"; replaced deprecated method from off-dart 1.24.0
* `product_list_import_export.dart`: replaced deprecated method from off-dart 1.24.0
* `product_list_page.dart`: replaced deprecated method from off-dart 1.24.0
* `pubspec.lock`: generated
* `pubspec.yaml`: upgrade to off-dart 1.24.0
@codecov-commenter
Copy link

Codecov Report

Merging #2795 (cafcd02) into develop (2ea0da3) will decrease coverage by 1.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2795      +/-   ##
==========================================
- Coverage     8.86%   7.01%   -1.86%     
==========================================
  Files          161     218      +57     
  Lines         6623   10698    +4075     
==========================================
+ Hits           587     750     +163     
- Misses        6036    9948    +3912     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 62.26% <0.00%> (-20.72%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) ⬇️
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 2.50% <0.00%> (-2.27%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
... and 237 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki merged commit 133071d into openfoodfacts:develop Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "to be completed products" are… completed
2 participants