fix: #1538 - refactoring of image cropper #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `confirm_and_upload_picture.dart`: minor refactoring. * `image_crop_page.dart`: rather heavy refactoring needed to move forward.
Impacted files: * `confirm_and_upload_picture.dart`: minor refactoring. * `image_crop_page.dart`: rather heavy refactoring needed to move forward.
Impacted files: * `confirm_and_upload_picture.dart`: minor refactoring. * `image_crop_page.dart`: rather heavy refactoring needed to move forward.
g123k
requested changes
Aug 29, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2858 +/- ##
==========================================
- Coverage 7.05% 7.04% -0.01%
==========================================
Files 219 219
Lines 10864 10871 +7
==========================================
Hits 766 766
- Misses 10098 10105 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Impacted files: * `image_crop_page.dart`: vertical buttons for gallery/camera dialog * `smooth_alert_dialog.dart`: fixed comment
|
Thanks @monsieurtanuki @g123k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
confirm_and_upload_picture.dart: minor refactoring.image_crop_page.dart: rather heavy refactoring needed to move forward.What
Part of