-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #2846 horizontal layout buttons #2899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Ty @abughalib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abughalib!
The code looks code, but the screenshot does not, as there's no space between the "save" button and the right side of the screen.
Could you please add screenshots for the 3 cases, and add horizontal spaces if needed?
Thank you @abughalib! |
I'd prefer to not block this pr, having a bit off spacing is better then the whole buttons not aligned |
@M123-dev I don't block anything: I just give my opinion as required. |
Codecov Report
@@ Coverage Diff @@
## develop #2899 +/- ##
==========================================
- Coverage 6.71% 6.70% -0.01%
==========================================
Files 228 228
Lines 11117 11118 +1
==========================================
Hits 746 746
- Misses 10371 10372 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @abughalib!
What
Part of
fixes #2846