chore: migrate to OFF SDK 1.26.0 #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
✏️ Editing - Nutrition input
🥫 Product page
🧪 Tests
labels
M123-dev
commented
Oct 14, 2022
There was a problem hiding this comment.
@monsieurtanuki I have some open questions for the migration to off-dart 1.26.0
Comment on lines
+271
to
+273
| !Nutrient.values.map((Nutrient e) { | ||
| return e.offTag; | ||
| }).contains(nutrient.id)) { |
There was a problem hiding this comment.
I'm not sure if this is the right way to go
packages/smooth_app/lib/pages/product/nutrition_page_loaded.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/nutrition_page_loaded.dart
Outdated
Show resolved
Hide resolved
M123-dev
changed the title
VaiTon
changed the title
There was a problem hiding this comment.
Hi @M123-dev!
Some minor comments that need to be addressed.
packages/smooth_app/lib/pages/product/nutrition_page_loaded.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_world_map_card.dart
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3153 +/- ##
==========================================
+ Coverage 6.17% 6.19% +0.02%
==========================================
Files 248 248
Lines 12491 12439 -52
==========================================
Hits 771 771
+ Misses 11720 11668 -52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
monsieurtanuki
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updated openfoodfacts-dart to 1.26.0