Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add launch.json for vscode #3166

Merged
merged 1 commit into from
Oct 18, 2022
Merged

chore: add launch.json for vscode #3166

merged 1 commit into from
Oct 18, 2022

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Oct 16, 2022

Adds a shortcut to launch Flutter from vs code by using the debug panel.

Adds a shortcut to launch Flutter from vs code by using the debug panel.
@VaiTon VaiTon self-assigned this Oct 16, 2022
@VaiTon VaiTon requested a review from a team as a code owner October 16, 2022 19:04
@codecov-commenter
Copy link

Codecov Report

Merging #3166 (96fc4ff) into develop (adb7716) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #3166   +/-   ##
=======================================
  Coverage     6.19%   6.19%           
=======================================
  Files          248     248           
  Lines        12439   12439           
=======================================
  Hits           771     771           
  Misses       11668   11668           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AshAman999 AshAman999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea seems good to me, but wouldn't it be defaulting it to launch just android, what about the iOS,
maybe if we can put a comment in JSON, but as far as I know, JSON doesn't support comments.

I am just curious about this question 🤔

@VaiTon
Copy link
Member Author

VaiTon commented Oct 17, 2022

The fact is that I don't have macOS, so I'm not able to test it. I could add F-Droid to the launch.json. Feel free to contribute though

@VaiTon VaiTon merged commit 3b2a12f into develop Oct 18, 2022
@VaiTon VaiTon deleted the chore/launch_json branch October 18, 2022 10:38
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants