Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #3188 - colored button for "ignore" in hunger games #3195

Merged
merged 1 commit into from
Oct 23, 2022
Merged

fix: #3188 - colored button for "ignore" in hunger games #3195

merged 1 commit into from
Oct 23, 2022
+23 −25

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • question_answers_options.dart: now using for "ignore" a button similar to yes/no
  • question_card.dart: created a shared Color

What

  • The "ignore" button had for some reason a different behavior from yes and no. One side effect being that it was not legible in dark mode.
  • Now it uses a similar button to yes and no, and looks similar to the website UI too.

Screenshot

light dark
Capture d’écran 2022-10-23 à 11 45 53 Capture d’écran 2022-10-23 à 11 46 24

Website:
Capture d’écran 2022-10-23 à 11 50 47

Fixes bug(s)

@monsieurtanuki
fix: openfoodfacts#3188 - colored button for "ignore" in hunger games
4864589 
Impacted files:
* `question_answers_options.dart`: now using for "ignore" a button similar to yes/no
* `question_card.dart`: created a shared `Color`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner October 23, 2022 09:51
@codecov-commenter
Copy link

Codecov Report

Merging #3195 (4864589) into develop (f8444b7) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop   #3195   +/-   ##
=======================================
  Coverage     6.17%   6.17%           
=======================================
  Files          252     252           
  Lines        12503   12502    -1     
=======================================
  Hits           772     772           
+ Misses       11731   11730    -1
Impacted Files Coverage Δ
...b/pages/hunger_games/question_answers_options.dart 0.00% <0.00%> (ø)
...ooth_app/lib/pages/hunger_games/question_card.dart 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AshAman999
AshAman999 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@AshAman999 AshAman999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@monsieurtanuki monsieurtanuki merged commit bf30f3e into openfoodfacts:develop Oct 23, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @AshAman999!

@github-actions github-actions bot mentioned this pull request Oct 23, 2022
Merged
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshAman999 AshAman999 AshAman999 approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
Hunger Games
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

Ignore button is illegible in dark mode
5 participants
@monsieurtanuki @codecov-commenter @AshAman999 @teolemon @M123-dev