Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "other" / "all" image manager #3245

Closed
monsieurtanuki opened this issue Nov 1, 2022 · 7 comments
Closed

Implement "other" / "all" image manager #3245

monsieurtanuki opened this issue Nov 1, 2022 · 7 comments

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Nov 1, 2022

What

  • The image manager should definitely be back at some point, possibly elsewhere.

Why

  • The list of other images is useful for:
    • moderation (spot bad images)
    • selecting images from server as front/ingredient/nutrition/packaging

Originally posted by @teolemon in #3241 (comment)

@teolemon
Copy link
Member

teolemon commented Nov 1, 2022

@monsieurtanuki
Copy link
Contributor Author

As already mentioned, we don't download "all" images when we download a product, we only download the 4 main images (as URL).
That's why we should either include "all" images when we download a product, OR put the management of "all" images in a dedicated page, to be accessed from the main image page.

Should we cache all image URLs, or just consider that the operation is so rare that we can assume the user is online and can await a call to the server. Hint: anyway, without network access, the images couldn't be downloaded either, so all image URL caching is not really an option here.

Basically, the all image page would display the mosaic of all images as thumbnails.

What are the operations we could do on each image? If I remember well, we could:

  • display it full screen
  • "delete" or deactivate an image (or something like that) (maybe it was "report!")
  • affect an image to one of the main 4 types (front, ingredients, front, recycling)
  • possibly crop/rotate the image, but I'm not sure how relevant it would be for "other" images

And we should be able to add an "other" image, shouldn't we? (it's not in #2351)

@teolemon Have I missed an important feature?

@teolemon
Copy link
Member

teolemon commented Nov 5, 2022

  • I believe this use case does not require any caching on the device.
    We can cache are the numerical ids for the existing images, but not the images themselves. We should start by making queries on the miniature version to provide a gridview, and make another query on press to show a large zoomable version.
  • Operations could be restricted to when you are online only, and only available from the zoomed version of the image.

image

Also, there's this view that was accessible from the carrousel in V1 (the carousel actually took this form - this is a mockup to reimplement). And we also had an optional tab of all available images that was directly visible on the product page

@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your remarks: we're more or less on the same page here.

About the off-dart side:

@monsieurtanuki
Copy link
Contributor Author

monsieurtanuki commented Nov 22, 2022

@monsieurtanuki
Copy link
Contributor Author

The list of other images is useful for:

  • moderation (spot bad images)
  • selecting images from server as front/ingredient/nutrition/packaging

Now the only thing not implemented yet is moderation.
Would probably be at the "all server image gallery" level.
We see this gallery when we click on "select an existing image" from the image page, and a short click on an image opens the selected image in the crop page.
Perhaps a long click could open a dialog about moderating this image, @teolemon?

@teolemon
Copy link
Member

teolemon commented Jan 2, 2024

Fixed. The reporting issue is being worked on at the nutripatrol repository, server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants