feat: Desktop support for dev (only tested on macOS) #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🤗 Onboarding
Codecov Report
@@ Coverage Diff @@
## develop #3251 +/- ##
==========================================
- Coverage 7.86% 7.85% -0.01%
==========================================
Files 250 250
Lines 12315 12320 +5
==========================================
Hits 968 968
- Misses 11347 11352 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
reviewed
Nov 1, 2022
g123k
changed the title
VaiTon
changed the title
teolemon
approved these changes
Nov 1, 2022
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
monsieurtanuki
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few changes in the code, the app is runnable on macOS.
I can't test on Windows and Linux, but at least on this platform, it seems OK