Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SignUp Issue #3288

Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix: SignUp Issue #3288

merged 3 commits into from
Nov 8, 2022

Conversation

Akashsri3bi
Copy link
Contributor

What

For Incorrect Email there was long html response which has been fixed in this PR

@Akashsri3bi Akashsri3bi requested a review from a team as a code owner November 8, 2022 13:31
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label Nov 8, 2022
M123-dev
M123-dev approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Akashsri3bi

Edit:

It does but what is missed is the analyzer. You have to also commit the pubspec.yaml and pubspec.lock

@Akashsri3bi
Copy link
Contributor Author

Looks good, thanks @Akashsri3bi

Edit:

It does but what is missed is the analyzer. You have to also commit the pubspec.yaml and pubspec.lock

Sure @M123-dev !

AshAman999
AshAman999 approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@AshAman999 AshAman999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too !

@M123-dev M123-dev merged commit 115c791 into openfoodfacts:develop Nov 8, 2022
@github-actions github-actions bot mentioned this pull request Nov 8, 2022
Merged
@Akashsri3bi
Copy link
Contributor Author

Looks good to me too !

Thanks !!

@monsieurtanuki monsieurtanuki mentioned this pull request Nov 10, 2022
Closed
@Akashsri3bi Akashsri3bi deleted the ak4 branch January 3, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

@AshAman999 AshAman999 AshAman999 approved these changes

Assignees

@Akashsri3bi Akashsri3bi

Labels
dependencies 👥 User management Account login, signup, signout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akashsri3bi @M123-dev @AshAman999