fix: 3018 - now there's only one place where we upload pictures from #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted file: * `picture_capture_helper.dart`: moved code to `ConfirmAndUploadPicture`, that is now the only place where we upload images Impacted files: * `add_new_product_page.dart`: minor refactoring * `background_task_details.dart`: minor refactoring * `background_task_image.dart`: minor refactoring * `confirm_and_upload_picture.dart`: minor refactoring; moved here code from `picture_capture_helper.dart` * `edit_ingredients_page.dart`: replaced `uploadCapturedPicture` with a call to page `ConfirmAndUploadPicture` * `image_crop_page.dart`: refactored into a single `startImageCropping` method * `image_upload_page.dart`: replaced `uploadCapturedPicture` with a call to page `ConfirmAndUploadPicture` * `new_crop_page.dart`: minor refactoring * `product_image_gallery_view.dart`: replaced `uploadCapturedPicture` with a call to page `ConfirmAndUploadPicture`; refactoring around refresh * `product_image_viewer.dart`: minor refactoring * `up_to_date_product_provider.dart: removed old-fashioned code
github-actions
bot
added
🖼️ Photos - Cropping
Product addition
Codecov Report
@@ Coverage Diff @@
## develop #3323 +/- ##
===========================================
+ Coverage 10.47% 10.48% +0.01%
===========================================
Files 252 251 -1
Lines 12335 12322 -13
===========================================
Hits 1292 1292
+ Misses 11043 11030 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Nov 15, 2022
| @@ -1,9 +1,12 @@ | |||
| import 'dart:convert'; | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:flutter/material.dart'; | |||
| import 'package:flutter_gen/gen_l10n/app_localizations.dart'; | |||
There was a problem hiding this comment.
Never seen that path before but when CI doesn't complain I'm fine with that
There was a problem hiding this comment.
@M123-dev Then you never started a localized page, because it's all over the place (96 occurrences...).
For some reason my Android Studio seems to have problems suggesting that import; that's how I learned it the hard way and copied/pasted again and again for each new localized page.
There was a problem hiding this comment.
I guess then my first assumption was wrong then, I have the same problem with the import. I just thought it was a different path
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted file:
picture_capture_helper.dart: moved code toConfirmAndUploadPicture, that is now the only place where we upload imagesImpacted files:
add_new_product_page.dart: minor refactoringbackground_task_details.dart: minor refactoringbackground_task_image.dart: minor refactoringconfirm_and_upload_picture.dart: minor refactoring; moved here code frompicture_capture_helper.dartedit_ingredients_page.dart: replaceduploadCapturedPicturewith a call to pageConfirmAndUploadPictureimage_crop_page.dart: refactored into a singlestartImageCroppingmethodimage_upload_page.dart: replaceduploadCapturedPicturewith a call to pageConfirmAndUploadPicturenew_crop_page.dart: minor refactoringproduct_image_gallery_view.dart: replaceduploadCapturedPicturewith a call to pageConfirmAndUploadPicture; refactoring around refreshproduct_image_viewer.dart: minor refactoringup_to_date_product_provider.dart: removed old-fashioned codeWhat
Part of