-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: In app review #3333
feat: In app review #3333
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3333 +/- ##
========================================
Coverage 10.48% 10.49%
========================================
Files 251 254 +3
Lines 12322 12352 +30
========================================
+ Hits 1292 1296 +4
- Misses 11030 11056 +26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
There's no review form now, am I right?
Right now, it's only when the user logs in.
We need a tool for that |
https://forms.gle/AuNZG6fXyAPqN5tL7", |
Ok, so we need a tool to store it. Since this is another development, I think having a dedicated issue would be better |
We need a extra screen to avoid negative reviews: Do you like the app ? Yes > Rating No > Form/Email |
cf. #1299 (comment)
How compatible would that be with |
We can use the Store dialog only if it's a yes. |
Locally:
|
Maybe let's the question otherwise. Is-it OK for this first implementation and add the other features in another PR? |
My personal opinion: the priority is to avoid bad ratings, so I would discuss it first before giving angry users an easy access to ratings. |
I would say we can merge if we already have the logged in criteria |
And we can keep the form redirect to a subsequent PR. The absolute priority right now is packaging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @g123k
@@ -0,0 +1,26 @@ | |||
# Miscellaneous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mentioned it a while back in another review already. I'd rather have one global .gitignore
with some local overrides then a lot of them all over the place
@@ -0,0 +1,30 @@ | |||
# Miscellaneous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Co-authored-by: Marvin M <39344769+M123-dev@users.noreply.github.com>
Merging the rating system. Thank you so much @g123k |
This feature allows the user to rate the app on the App Store/Google Play/other stores based on URI (F-Droid for example)
Like the scanner, we have multiple dependencies and we selected the right one according to the output.
Will fix #1299
(Feel free to change the content of the dialog)