Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update assets #3382

Merged
merged 2 commits into from
Dec 9, 2022
Merged

chore: Update assets #3382

merged 2 commits into from
Dec 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Automated update of asset cache

@github-actions github-actions bot requested a review from a team as a code owner November 29, 2022 19:00
M123-dev
M123-dev requested changes Nov 29, 2022
View reviewed changes
packages/smooth_app/assets/onboarding/sample_product_data.json Outdated
@@ -1242,7 +1242,7 @@
"level" : "info",
"title_element" : {
"grade" : "a",
"subtitle" : "Product: A good product for you - Open Food Facts - 200 g",
"subtitle" : "Product: A good product for you - Open Food Facts - text",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks wrong @stephanegigandet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like someone used Smoothie to change the quantity to "text":

https://world.openfoodfacts.org/product/093270067481501/a-good-product-for-you-open-food-facts

November 28, 2022 at 9:35:19 PM CET - smoothie-app Data (Changed: quantity) - (app)- Smoothie - OpenFoodFacts - 4.0.0+833 - android+MTC20F - view

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-20221130-111311.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be possible from the onboarding

@teolemon teolemon mentioned this pull request Nov 30, 2022
Closed
@github-actions github-actions bot force-pushed the auto-update-assets branch 2 times, most recently from 44e7c02 to f39afa5 Compare December 1, 2022 19:01
@M123-dev
Copy link
Member

M123-dev commented Dec 1, 2022

Ohh new updates, looks like the new algorithm has changed a lot of the scores? 🥳

@teolemon
Copy link
Member

teolemon commented Dec 1, 2022

25% of Eco-Scores changing @M123-dev

@github-actions github-actions bot force-pushed the auto-update-assets branch 5 times, most recently from 7391311 to 984aed5 Compare December 6, 2022 19:00
@teolemon teolemon self-assigned this Dec 8, 2022
@github-actions github-actions bot added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Dec 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3382 (892a8b2) into develop (d3aea55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3382   +/-   ##
========================================
  Coverage    10.35%   10.35%           
========================================
  Files          259      259           
  Lines        12551    12551           
========================================
  Hits          1300     1300           
  Misses       11251    11251

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VaiTon VaiTon requested review from teolemon and M123-dev December 9, 2022 18:19
@teolemon teolemon merged commit cf3ce7f into develop Dec 9, 2022
@teolemon teolemon deleted the auto-update-assets branch December 9, 2022 21:05
@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@stephanegigandet stephanegigandet stephanegigandet left review comments

@M123-dev M123-dev Awaiting requested review from M123-dev

Assignees

@teolemon teolemon

Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M123-dev @teolemon @codecov-commenter @stephanegigandet