Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3493 - structured packagings +quantity +weight and localized #3500

Merged
merged 3 commits into from
Jan 2, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_en.arb: added 9 labels for "structured packagings"
  • edit_new_packagings.dart: added fields quantity and weight for each element; localized; padding around the "add element" button; padding on top of the first element; cleared hintTexts
  • edit_product_page.dart: localized the "structured packagings" item title

What

  • 2 new fields (quantity and weight) for the elements of structured packagings.
  • Localization, paddings.
  • Actually saving to the server.

Screenshot

top bottom
Capture d’écran 2023-01-02 à 19 22 39 Capture d’écran 2023-01-02 à 19 24 55

Fixes bug(s)

Impacted files:
* `app_en.arb`: added 9 labels for "structured packagings"
* `edit_new_packagings.dart`: added fields quantity and weight for each element; localized; padding around the "add element" button; padding on top of the first element; cleared `hintText`s
* `edit_product_page.dart`: localized the "structured packagings" item title
@teolemon teolemon added the ✏️ Editing - Packaging input Related to the structured input of food packaging. label Jan 2, 2023
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
@monsieurtanuki monsieurtanuki merged commit 9631da6 into openfoodfacts:develop Jan 2, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Packaging input Related to the structured input of food packaging. 🌐 l10n 🥫 Product page
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Structured packaging input screen
2 participants