fix: moved robotoff questions on product page #3549

prathamsoni11 · 2023-01-08T05:04:53Z

What

Moved Robotoff Questions on the Product Page

Screenshot

Part of

Inline Robotoff questions to increase the answer rate #3326

teolemon

Can we have red for no, green for yes, gray for Skip, and in the same order as the server (you can have a better layout though :-) )

prathamsoni11 · 2023-01-08T14:52:39Z

Can we have red for no, green for yes, gray for Skip, and in the same order as the server (you can have a better layout though :-) )

VaiTon · 2023-01-09T14:07:17Z

Hey @prathamsoni11! I see that beside the product page file you also modified the "standalone" screen. Is that useful to this PR or we could split it into another PR?

M123-dev · 2023-01-09T15:26:02Z

Hey prathamsoni11! I see that beside the product page file you also modified the "standalone" screen. Is that useful to this PR or we could split it into another PR?'

Yes, definitely. We should keep both for hunger games. Also, what happens when you are done with the questions. Does the card disappear or is the congrats page opened.

prathamsoni11 · 2023-01-09T16:20:38Z

Hey prathamsoni11! I see that beside the product page file you also modified the "standalone" screen. Is that useful to this PR or we could split it into another PR?'

Yes, definitely. We should keep both for hunger games. Also, what happens when you are done with the questions. Does the card disappear or is the congrats page opened.

@VaiTon @M123-dev This is a past screen recording ignore the arrangement and background colour of the buttons. In this, all the components are covered.

Screenrecorder-2022-12-09-18-12-37-631.mp4

M123-dev · 2023-01-09T16:42:01Z

Looks great, there are some merge conflicts, and we should keep the inline separate from the full page, we'll need both

prathamsoni11 · 2023-01-11T14:34:41Z

Looks great, there are some merge conflicts, and we should keep the inline separate from the full page, we'll need both

I didn't get what exactly you are saying. Can you explain it briefly?

M123-dev · 2023-01-17T06:39:18Z

Yes @prathamsoni11 , so if you go into the devmodes and activate hungergames then you can find it in Settings-> contribute-> Hungergames

There we need the full Page variant of these questions, so we need two versions

One full page version with a scaffold for Hungergames
And one inline version for the product page

Some parts of the logic can surely be shared between them, but I'd recommend to have different widgets per version

prathamsoni11 · 2023-01-20T09:31:32Z

Yes @prathamsoni11 , so if you go into the devmodes and activate hungergames then you can find it in Settings-> contribute-> Hungergames

There we need the full Page variant of these questions, so we need two versions

One full page version with a scaffold for Hungergames

And one inline version for the product page

Some parts of the logic can surely be shared between them, but I'd recommend to have different widgets per version

Is there any design ready that needs to be implemented or should I have to use the old one?

prathamsoni11 · 2023-01-20T09:37:23Z

There are two ways to implement:-

We can implement a new widget.
We can handle the same widget if it is redirected from Hungergames.

M123-dev · 2023-01-24T15:29:28Z

I would suggest to leave the old implementation untouched and create a new widgets for the inline card on the product page @prathamsoni11

prathamsoni11 · 2023-02-28T05:16:56Z

I would suggest to leave the old implementation untouched and create a new widgets for the inline card on the product page @prathamsoni11

@M123-dev This is the result after creating a new Widget. Is this good?

M123-dev · 2023-02-28T18:03:23Z

Ohh sorry if I was unclear in my request, I didn't mean the full page to be new created.

We need two pages:

The hunger games page, which is fullscreen and shows the product images as well as the question
The widget which is embedded on the product page, only shows the question as the other infos are already on the same page

We have to find a way so that both of them work, as expected. That is why I recommended to leave the full page hungergames unchanged and just create a new widget for the product page

I hope my explanation can be understood

prathamsoni11 · 2023-03-01T06:30:45Z

Ohh sorry if I was unclear in my request, I didn't mean the full page to be new created.

We need two pages:

The hunger games page, which is fullscreen and shows the product images as well as the question

The widget which is embedded on the product page, only shows the question as the other infos are already on the same page

We have to find a way so that both of them work, as expected. That is why I recommended to leave the full page hungergames unchanged and just create a new widget for the product page

I hope my explanation can be understood

ok, I will restore hungergames page to default and implement a new widget for the product page.

M123-dev · 2023-03-01T15:04:45Z

Perfect, that is exactly what I had in mind

prathamsoni11 · 2023-03-04T07:02:00Z

Perfect, that is exactly what I had in mind

Done👍🏻

M123-dev

Heyy @prathamsoni11 looks amazing, I'm sure this will lead to way more usage.

Added a few comments all of them very small ones to be fixed in a few seconds.

But there are some merge conflicts which have to be resolved before we can merge

M123-dev · 2023-03-08T17:24:03Z

packages/smooth_app/lib/pages/hunger_games/congrats.dart

+              style: Theme.of(context).textTheme.bodyText1!.apply(
+                    color: isDarkMode ? Colors.white : Colors.black,
+                  ),


Are those changes necessary, this will likely look out of place in the coming AMOLED mode

M123-dev · 2023-03-08T17:24:33Z

packages/smooth_app/lib/pages/hunger_games/congrats.dart

+              style: TextStyle(
+                color: isDarkMode ? Colors.white : Colors.black,
+              ),


Same here, but if these colors are indeed needed, please use Theme.of(context).textTheme.bodyText1!.apply( as above

M123-dev · 2023-03-08T17:26:17Z

packages/smooth_app/lib/pages/product/product_question_answers_options.dart

+Color _yesBackground = Colors.green;
+Color _noBackground = Colors.red;
+const Color _maybeBackground = Colors.white;
+const Color _yesNoTextColor = Colors.white;
+Color _maybeTextColor = Colors.grey.shade700;


Can you move them inside the ProductQuestionAnswersOptions also all of them could be const, right?

M123-dev · 2023-03-08T17:26:53Z

packages/smooth_app/lib/pages/product/product_question_card.dart

+    );
+  }
+
+  Widget _buildQuestionShimmer() => Shimmer.fromColors(


Still love this shimmer effect ;D

M123-dev · 2023-03-08T17:29:20Z

packages/smooth_app/lib/pages/product/product_question_page.dart

+import 'package:smooth_app/query/product_questions_query.dart';
+import 'package:smooth_app/query/questions_query.dart';
+
+class ProductQuestionPage extends StatefulWidget {


I wouldn't call it a page, maybe ProductQuestionWidget or something like that (also the filename)

adilwahla

good 👍

teolemon · 2023-03-16T16:21:39Z

@prathamsoni11 we need a rebase on develop

M123-dev

I'm going to merge this now. Thanks for your work @prathamsoni11

teolemon · 2023-04-07T08:22:21Z

@M123-dev @prathamsoni11 this has been merged, but I can't see the new behaviour in the app. Am I missing something ?

moved robotoff quesrions on product page

85a03c2

prathamsoni11 requested a review from a team as a code owner January 8, 2023 05:04

github-actions bot assigned prathamsoni11 Jan 8, 2023

github-actions bot added Hunger Games 🥫 Product page summary card PR: needs rebase labels Jan 8, 2023

teolemon reviewed Jan 8, 2023

View reviewed changes

prathamsoni11 added 2 commits January 8, 2023 20:15

changed colors of buttons

a0f4c60

changed positions of buttons

85f7ad8

openfoodfacts deleted a comment from prathamsoni11 Jan 24, 2023

prathamsoni11 added 2 commits March 4, 2023 12:11

new widget created for product page

a8fa706

restored hunger games question page

e69a224

question page changed to product

416b439

M123-dev reviewed Mar 8, 2023

View reviewed changes

adilwahla reviewed Mar 16, 2023

View reviewed changes

M123-dev added 2 commits March 16, 2023 18:46

Merge branch 'develop' into pr/3549

9ed3782

fix conflicts

110410e

github-actions bot removed summary card PR: needs rebase labels Mar 16, 2023

fix

8b32307

teolemon added the 🤖 Robotoff label Mar 20, 2023

Merge branch 'develop' into inline-robotoff-questions

20e1ade

github-actions bot removed the 🤖 Robotoff label Mar 20, 2023

M123-dev added 3 commits March 21, 2023 18:23

Merge branch 'develop' into inline-robotoff-questions

3843906

New flutter version

7534b50

.

6f9f303

M123-dev approved these changes Mar 21, 2023

View reviewed changes

M123-dev merged commit 4b3f2e7 into openfoodfacts:develop Mar 21, 2023

github-actions bot mentioned this pull request Mar 21, 2023

chore(develop): release 4.7.0 #3778

Merged

teolemon mentioned this pull request Jun 10, 2023

feat: Question page in a Dialog-like container (+ some fixes) #4109

Merged

g123k mentioned this pull request Jun 16, 2023

Inline Robotoff questions to increase the answer rate #3326

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: moved robotoff questions on product page #3549

fix: moved robotoff questions on product page #3549

prathamsoni11 commented Jan 8, 2023

teolemon left a comment •

edited

Loading

prathamsoni11 commented Jan 8, 2023

VaiTon commented Jan 9, 2023

M123-dev commented Jan 9, 2023

prathamsoni11 commented Jan 9, 2023

M123-dev commented Jan 9, 2023

prathamsoni11 commented Jan 11, 2023

M123-dev commented Jan 17, 2023 •

edited

Loading

prathamsoni11 commented Jan 20, 2023

prathamsoni11 commented Jan 20, 2023

M123-dev commented Jan 24, 2023

prathamsoni11 commented Feb 28, 2023

M123-dev commented Feb 28, 2023

prathamsoni11 commented Mar 1, 2023

M123-dev commented Mar 1, 2023

prathamsoni11 commented Mar 4, 2023

M123-dev left a comment

M123-dev Mar 8, 2023

M123-dev Mar 8, 2023

M123-dev Mar 8, 2023

M123-dev Mar 8, 2023

M123-dev Mar 8, 2023

adilwahla left a comment

teolemon commented Mar 16, 2023

M123-dev left a comment

teolemon commented Apr 7, 2023

fix: moved robotoff questions on product page #3549

fix: moved robotoff questions on product page #3549

Conversation

prathamsoni11 commented Jan 8, 2023

What

Screenshot

Part of

teolemon left a comment • edited Loading

Choose a reason for hiding this comment

prathamsoni11 commented Jan 8, 2023

VaiTon commented Jan 9, 2023

M123-dev commented Jan 9, 2023

prathamsoni11 commented Jan 9, 2023

M123-dev commented Jan 9, 2023

prathamsoni11 commented Jan 11, 2023

M123-dev commented Jan 17, 2023 • edited Loading

prathamsoni11 commented Jan 20, 2023

prathamsoni11 commented Jan 20, 2023

M123-dev commented Jan 24, 2023

prathamsoni11 commented Feb 28, 2023

M123-dev commented Feb 28, 2023

prathamsoni11 commented Mar 1, 2023

M123-dev commented Mar 1, 2023

prathamsoni11 commented Mar 4, 2023

M123-dev left a comment

Choose a reason for hiding this comment

M123-dev Mar 8, 2023

Choose a reason for hiding this comment

M123-dev Mar 8, 2023

Choose a reason for hiding this comment

M123-dev Mar 8, 2023

Choose a reason for hiding this comment

M123-dev Mar 8, 2023

Choose a reason for hiding this comment

M123-dev Mar 8, 2023

Choose a reason for hiding this comment

adilwahla left a comment

Choose a reason for hiding this comment

teolemon commented Mar 16, 2023

M123-dev left a comment

Choose a reason for hiding this comment

teolemon commented Apr 7, 2023

teolemon left a comment •

edited

Loading

M123-dev commented Jan 17, 2023 •

edited

Loading