Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3535 - padding added to crop tool #3551

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • new_crop_page.dart: added a Padding

What

Screenshot

before after
Capture d’écran 2023-01-08 à 13 43 13 Capture d’écran 2023-01-08 à 13 43 46
Capture d’écran 2023-01-08 à 13 44 30 Capture d’écran 2023-01-08 à 13 44 00

Fixes bug(s)

Impacted file:
* `new_crop_page.dart`: added a `Padding`
@codecov-commenter
Copy link

Codecov Report

Merging #3551 (8f9310f) into develop (3291201) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3551      +/-   ##
===========================================
- Coverage    11.08%   11.08%   -0.01%     
===========================================
  Files          262      262              
  Lines        12943    12944       +1     
===========================================
  Hits          1435     1435              
- Misses       11508    11509       +1     
Impacted Files Coverage Δ
...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki merged commit 3d142f4 into openfoodfacts:develop Jan 8, 2023
@VaiTon
Copy link
Member

VaiTon commented Jan 8, 2023

Thank you!

@monsieurtanuki
Copy link
Contributor Author

@VaiTon You're welcome! To be honest that was not my toughest PR! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's impossible to crop vertical/portrait photos because buttons are over the handles in the corners
3 participants