Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simpler project structure #3555

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

M123-dev
Copy link
Member

@M123-dev M123-dev commented Jan 9, 2023

What

Fixes: #3503
Followup from #3465

Before we had the dart entry points (void main) in /app/ together with the needed packages in the pubspec in /app/
This was unnecessary as the same can be achieved in the main code package /smooth_app/

Also this caused problems not only with pub on windows machines see #3503 and endless slack help requests but also problems with git bundled with an older win32 version which included max file length which was triggered by the nested code. (app/packages/smooth_app/packages/)

The main changes:

  • moved the android, iOS, windows, ..., folder from /app/ to /smooth_app/
  • Set one variable in smooth_app to null so that the assets again work
  • Edited the entry points (the run button on the top now works again)
  • Updated all workflows and scripts to work with this change

@M123-dev M123-dev requested a review from a team as a code owner January 9, 2023 16:04
@github-actions github-actions bot added Android dependencies 📚 Documentation Improvements or additions to documentation fastlane Automation of releases and marketing assets deployment GitHub 🍎 iOS iOS specific issues or PRs MacOS 🧪 Tests labels Jan 9, 2023
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M123-dev!
I cannot review 226 files and I don't understand fully the implications of what you're doing.
If you tested and if today the app smooth_app can be built correctly, that's good enough for me.

@M123-dev
Copy link
Member Author

M123-dev commented Jan 9, 2023

Local works without problems, but there is always a bit of luck involved with the automatic release. 🤞🏼

@M123-dev M123-dev merged commit 199e27e into develop Jan 9, 2023
@M123-dev M123-dev deleted the refactor-Project-structure branch January 9, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android dependencies 📚 Documentation Improvements or additions to documentation fastlane Automation of releases and marketing assets deployment GitHub 🍎 iOS iOS specific issues or PRs MacOS 🧪 Tests
Development

Successfully merging this pull request may close these issues.

Build fails in Windows OS
2 participants